Re: [PATCH] iio: humidity: hts221: Fix checkpatch blank line warning

On Mon, Aug 3, 2026 at 1:12 AM Jonathan Cameron <[email protected]> wrote:
>
> On Sun, 2 Aug 2026 17:38:52 +0200
> Joshua Crofts <[email protected]> wrote:
>
>
> True.  This highlights a broader point.  When making
> a number of cleanups to a driver (and I am generally more willing
> to take those than many maintainers) please group them into
> a little patch series with a cover letter.
>
> If this is one of a set and overall the seem worthwhile I might
> pick them up.  Plus this driver is pretty aged so there are other
> quality of code / modernization things that will make much more
> of an impact than just this blank line.  Take a look at some
> of the other similar cleanup series on the IIO list and see what
> makes sense here. To give you a starter, dev_err_probe() and
> checking which prints are actually useful + stopping the driver
> rejecting Device tree falllback compatibles because of the hard
> fail on a device ID mismatch.
>
> >
> > Also, I feel like just putting checkpatch warnings directly into the
> > commit message is bad practice. Much better if it were "Add a blank line
> > after variable declarations per checkpatch warning."
>
> Fully agree with this.  We really don't care what the print is, just
> what is being improved and why.
>
> Thanks
>
> Jonathan
>

Hi Jonathan and Joshua,

Thank you for the advice. I will create a new patch series with a cover letter
for this hts221 driver accordingly based on your feedback.

Regards,
Adi Nata