Re: discuss about commit 3b0f9ce: filter-mpath: get wwids from sysfs vpd_pg83
David Teigland <[email protected]>
| Newsgroups | dev.linux.lists.linux-lvm |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Nov 15, 2023 at 07:36:57PM +0800, Heming Zhao wrote: > From the lvm2 code, above description is wrong. By default, system/devices is > disabled status. Because lvm.conf option "use_devicesfile = 0" by default. > under "use_devicesfile = 0", any pvcreate/vgcreate/lvmdevices/vgimportdevices > won't generate/create system/devices file. > If my watching is correct, part discussion of this thread may invalid. The lvm default is use_devicesfile=1, as shown in this commit: commit 6c22392a3f903d6c086f7cc94978bdf8b072da6e Author: David Teigland <[email protected]> Date: Tue Mar 16 09:52:13 2021 -0500 config: change default use_devicesfile to 1 diff --git a/lib/config/defaults.h b/lib/config/defaults.h index 66eece53aa33..a7a2a06df654 100644 --- a/lib/config/defaults.h +++ b/lib/config/defaults.h @@ -322,7 +322,7 @@ #define DEFAULT_MD_COMPONENT_CHECKS "auto" -#define DEFAULT_USE_DEVICES_FILE 0 +#define DEFAULT_USE_DEVICES_FILE 1 #define DEFAULT_DEVICES_FILE "system.devices" Later commits that removed DEFAULT_USE_DEVICES_FILE, and tried to replace it with a configure option, was a failed attempt at building that lvm source for RHEL8. It's caused no end of problems and I plan to revert it and restore define DEFAULT_USE_DEVICES_FILE 1. Dave