Re: [PATCH 6/6] multipathd: don't activate socket activation by default

On Mon, Feb 05, 2024 at 01:46:38PM +0100, Martin Wilck wrote:
> Socket activation will start multipathd on systems that don't have multipath
> hardware. This is often not desired.  On systems that do have multipath
> hardware, OTOH, it is highly recommended to enable multipathd.service directly
> rather than have it started via socket activation.  Therefore don't activate
> the socket by default.  multipathd still supports socket activation, so users
> who find it useful can disable multipathd.service and activate the socket.
> 
> Fixes: https://github.com/opensvc/multipath-tools/issues/76
> Signed-off-by: Martin Wilck <[email protected]>
> Cc: Sergio Durigan Junior <[email protected]>
> Cc: Chris Hofstaedtler <[email protected]>

Reviewed-by: Benjamin Marzinski <[email protected]>

> ---
>  multipathd/multipathd.socket | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/multipathd/multipathd.socket b/multipathd/multipathd.socket
> index c777e5e..6a62f5f 100644
> --- a/multipathd/multipathd.socket
> +++ b/multipathd/multipathd.socket
> @@ -10,4 +10,6 @@ Before=sockets.target
>  ListenStream=@/org/kernel/linux/storage/multipathd
>  
>  [Install]
> -WantedBy=sockets.target
> +# Socket activation for multipathd is disabled by default.
> +# Activate it here if you find it useful.
> +# WantedBy=sockets.target
> -- 
> 2.43.0