Re: [PATCH v3 1/1] Documentation: real-time: Add kernel configuration guide
| Newsgroups | dev.linux.lists.linux-rt-devel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Low] Reference to a non-existent Kconfig option 'CONFIG_WQ_SYSFS'. - [Low] Unused hyperlink target '_development work' is defined but never referenced. -- --- Patch [1]: [PATCH v3 1/1] Documentation: real-time: Add kernel configuration guide --- commit aafa57307e83d54cf2bd4f383aa2ee5d683dab92 Author: Ahmed S. Darwish <[email protected]> Documentation: real-time: Add kernel configuration guide This commit adds a configuration guide for real-time kernels. It lists Kconfig options that are recommended to be either enabled or disabled to help manage worst-case latency. > diff --git a/Documentation/core-api/real-time/kernel-configuration.rst b/Documentation/core-api/real-time/kernel-configuration.rst > new file mode 100644 > index 0000000000000..008d706f36cd2 > --- /dev/null > +++ b/Documentation/core-api/real-time/kernel-configuration.rst [ ... ] > +Alternatively, confine EFI runtime service calls to a housekeeping CPU by > +restricting the ``efi_runtime`` workqueue CPU affinity. For example, set > +that workqueue's affinity to CPU #0 and pin your RT tasks to a different > +CPU range. Note that exposing workqueues through sysfs requires having > +``CONFIG_WQ_SYSFS`` enabled. See :doc:`/core-api/workqueue`. [Severity: Low] Does CONFIG_WQ_SYSFS exist? Searching the Kconfig files doesn't show this option. Could this be confusing the WQ_SYSFS allocation flag used in the C code with a kernel configuration option? [ ... ] > +References > +========== > + > +.. [1] See :doc:`/admin-guide/kernel-parameters` > + > +.. _development work: https://lore.kernel.org/r/[email protected] [Severity: Low] This isn't a bug, but this hyperlink target is defined here and never referenced in the rest of the document. Will this cause the link to be invisible in the generated HTML documentation? -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1