Re: [PATCH RFC] arm64: dts: allwinner: a523: Add SPDIF to x96qproplus device

On Mon, 20 Jul 2026 22:59:57 +0800
Chen-Yu Tsai <[email protected]> wrote:

> On Sun, Jul 19, 2026 at 11:10 AM Per Larsson <[email protected]> wrote:
> >
> >
> > Signed-off-by: Per Larsson <[email protected]>
> > ---
> > Marking this as RFC for a few reasons
> > 1. This is my first submission, hoping everything is properly
> > organized.  
> 
> This is pretty good. The commit message is also well written. I would
> like to see the patch split into two patches though. The first adds
> the pinmux (and you can mention in the commit message that a
> subsequent patch will reference it). The second patch enables SPDIF
> on the device you have.
> 
Ok, will split into two patches.

> > 2. My testing setup is not the best: I get sound with this patch,
> > but the pulseaudio daemon needs to be restarted far too often.
> >    Hopefully it's just something on this minirootfs. Testing
> > welcome. 3. Not sure where to get the hash for a fixes tag or if
> > that's even OK  
> 
> This is a new addition, not a fix, so no fixes tag is warranted.
> 
Understood.

Also saw that issue #2 in the list above was indeed because of issues in
my rootfs and not because of anything related to the patch, so no more
RFC-markings for next version.
> 
> Thanks
> ChenYu
> 
> > ---