Re: [PATCH 1/2] arm64: dts: allwinner: a523: Add missing SPDIF pin

On Mon, 20 Jul 2026 19:42:42 +0200
Per Larsson <[email protected]> wrote:

Hi,

thanks for takign the time to send a patch!

> When spdif support was added for the Allwinner A523 family of SoCs, only
> two of the three possible pins were added to the dtsi, since the third
> would clash with the first ethernet port (emac0)
> However, some devices don't use emac0 and instead use emac1 for the only
> available ethernet port, leaving the pin free to use for spdif.

Not sure we need such an elaborate excuse to add a pinmux that is
used on one device - you could just say *that* instead.
But that's not a big issue, as the patch itself is correct.


> Add the missing pin to the dtsi so such devices can (later) use it
> 
> Signed-off-by: Per Larsson <[email protected]>

Checked the details against the user manual: they match:

Reviewed-by: Andre Przywara <[email protected]>

Cheers,
Andre

> ---
>  arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> index ca6a16807049..7370e8ed24ec 100644
> --- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> @@ -216,6 +216,13 @@ spdif_out_pb_pin: spdif-pb-pin {
>  				allwinner,pinmux = <2>;
>  			};
>  
> +			/omit-if-no-ref/
> +			spdif_out_ph_pin: spdif-ph-pin {
> +				pins = "PH7";
> +				function = "spdif";
> +				allwinner,pinmux = <4>;
> +			};
> +
>  			/omit-if-no-ref/
>  			spdif_out_pi_pin: spdif-pi-pin {
>  				pins = "PI10";