Re: [PATCH v9 45/61] drm/bridge: lontium-lt9611: Advertise HDMI 1.4 capabilities

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Calling sleeping function msleep() from atomic context in lt9611_bridge_atomic_enable
--

--- Patch [45]: [PATCH v9 45/61] drm/bridge: lontium-lt9611: Advertise HDMI 1.4 capabilities ---
commit 68a26d2eb02093b29ceceec99268ce3f7d8ba524
Author: Cristian Ciocaltea <[email protected]>

drm/bridge: lontium-lt9611: Advertise HDMI 1.4 capabilities

This commit adds HDMI 1.4 capability advertisement to the lontium-lt9611 bridge.
It sets the supported version and maximum TMDS character rate.
It also removes the redundant lt9611_hdmi_tmds_char_rate_valid function.

> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
> index b6a368f712853..19971ffade8ba 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
[ ... ]
> @@ -1029,7 +1018,6 @@ static const struct drm_bridge_funcs lt9611_bridge_funcs = {
>  	.atomic_create_state = drm_atomic_helper_bridge_create_state,
>  	.atomic_get_input_bus_fmts = lt9611_atomic_get_input_bus_fmts,
>  
> -	.hdmi_tmds_char_rate_valid = lt9611_hdmi_tmds_char_rate_valid,
>  	.hdmi_write_audio_infoframe = lt9611_hdmi_write_audio_infoframe,
>  	.hdmi_clear_audio_infoframe = lt9611_hdmi_clear_audio_infoframe,

[Severity: High]
This is a pre-existing issue, but since we are modifying the bridge
capabilities here, I noticed a potential sleeping in atomic context issue
in the existing lt9611_bridge_atomic_enable function:

drivers/gpu/drm/bridge/lontium-lt9611.c:lt9611_bridge_atomic_enable() {
	...
	lt9611_hdmi_tx_digital(lt9611, connector->display_info.is_hdmi);
	lt9611_hdmi_tx_phy(lt9611);

	msleep(500);

	lt9611_video_check(lt9611);
	...
}

Is it safe to use msleep in this path?

DRM bridge atomic enable callbacks run in an atomic context during non-blocking
commits where sleeping is forbidden. Does this msleep cause scheduling while
atomic warnings or potential lockups when triggered via display mode setting or
hotplug events?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=45