Re: [PATCH v9 43/61] drm/bridge: ite-it6263: Advertise HDMI 1.3 capabilities

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The macro `MAX_HDMI_TMDS_CHAR_RATE_HZ` and its descriptive comment are now unused and should be removed.
--

--- Patch [43]: [PATCH v9 43/61] drm/bridge: ite-it6263: Advertise HDMI 1.3 capabilities ---
commit 30b48bebf03b99c913be112fadde6e8cf5c4b197
Author: Cristian Ciocaltea <[email protected]>

drm/bridge: ite-it6263: Advertise HDMI 1.3 capabilities

This commit advertises HDMI 1.3 support for the IT6263 bridge and drops the
redundant it6263_hdmi_tmds_char_rate_valid hook. The TMDS character rate
limit is now enforced via max_tmds_char_rate during connector atomic check.

> diff --git a/drivers/gpu/drm/bridge/ite-it6263.c b/drivers/gpu/drm/bridge/ite-it6263.c
> index f166bb38998c0..73caf28c6ac77 100644
> --- a/drivers/gpu/drm/bridge/ite-it6263.c
> +++ b/drivers/gpu/drm/bridge/ite-it6263.c
> @@ -738,20 +738,6 @@ it6263_bridge_atomic_get_input_bus_fmts(struct drm_bridge *bridge,
>  	return input_fmts;
>  }
>  
> -static enum drm_mode_status
> -it6263_hdmi_tmds_char_rate_valid(const struct drm_bridge *bridge,
> -				 const struct drm_display_mode *mode,
> -				 unsigned long long tmds_rate)
> -{
> -	if (mode->clock > MAX_PIXEL_CLOCK_KHZ)
> -		return MODE_CLOCK_HIGH;
> -
> -	if (tmds_rate > MAX_HDMI_TMDS_CHAR_RATE_HZ)

[Severity: Low]
Since this function is being removed, should the definition of
MAX_HDMI_TMDS_CHAR_RATE_HZ in drivers/gpu/drm/bridge/ite-it6263.c also be
removed? It appears this patch removes the only user, leaving the macro and
its associated comment as dead code.

> -		return MODE_CLOCK_HIGH;
> -
> -	return MODE_OK;
> -}
> -

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=43