Re: [PATCH v10 55/69] drm/sun4i: hdmi: Convert to drmm_connector_hdmi_init()

Thank you for your contribution! Sashiko AI review found 1 potential issue(=
s) to consider:
- [Low] A comment originally describing the vendor and product strings was =
left behind after the strings were moved to a struct, making it confusing.
--

--- Patch [55]: [PATCH v10 55/69] drm/sun4i: hdmi: Convert to drmm_connecto=
r_hdmi_init() ---
commit b114fe117b3fdd374cdabeb7a675643189411792
Author: Cristian Ciocaltea <[email protected]>
drm/sun4i: hdmi: Convert to drmm_connector_hdmi_init()

This patch switches the sun4i HDMI driver to use the new
drmm_connector_hdmi_init() signature. The vendor, product, format
capabilities, and max bpc are moved into the drm_connector_hdmi_funcs
structure.

> diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c b/drivers/gpu/drm/sun=
4i/sun4i_hdmi_enc.c
> --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c
> +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c

[ ... ]

> @@ -653,19 +654,16 @@ static int sun4i_hdmi_bind(struct device *dev, stru=
ct device *master,
> =20
>  	drm_connector_helper_add(&hdmi->connector,
>  				 &sun4i_hdmi_connector_helper_funcs);
> -	ret =3D drmm_connector_hdmi_ini2(drm, &hdmi->connector,
> +	ret =3D drmm_connector_hdmi_init(drm, &hdmi->connector,
>  				       /*
>  					* NOTE: Those are likely to be
>  					* wrong, but I couldn't find the
>  					* actual ones in the BSP.
>  					*/
> -				       "AW", "HDMI",
>  				       &sun4i_hdmi_connector_funcs,

[Severity: Low]
This isn't a bug, but should this comment be moved along with the "AW" and
"HDMI" strings to sun4i_hdmi_hdmi_connector_funcs? Leaving it here makes it
appear as if it refers to the sun4i_hdmi_connector_funcs argument.

>  				       &sun4i_hdmi_hdmi_connector_funcs,
>  				       DRM_MODE_CONNECTOR_HDMIA,
> -				       hdmi->ddc_i2c,
> -				       BIT(DRM_OUTPUT_COLOR_FORMAT_RGB444),
> -				       8);
> +				       hdmi->ddc_i2c);
>  	if (ret) {
>  		dev_err(dev,
>  			"Couldn't initialise the HDMI connector\n");

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260731-dw-hdmi-qp=
[email protected]?part=3D55