Re: [PATCH v7 1/9] rust: Introduce atomic API helpers
Miguel Ojeda <[email protected]> Wed, 16 Jul 2025 14:56:37 +0200
| Newsgroups | dev.linux.lists.lkmm,org.kernel.vger.linux-arch,org.kernel.vger.linux-kernel,org.kernel.vger.rust-for-linux |
|---|---|
| Message-ID | <CANiq72ms11yfBVjfpV9PH6LZ3g72-Wd=5dwda3ULxc0PTnP=NA@mail.gmail.com> |
On Wed, Jul 16, 2025 at 2:47 PM Peter Zijlstra <[email protected]> wrote: > > It depends on the scripts/atomic/* bits. They hardly if ever change. We > do it this way because: > > - generating these files every build is 'slow'-ish; > - code navigation suffers; > - Linus asked for this. > > Specifically, pretty much the entire atomic_*() namespace would > disappear from ctags / code-browsing-tool-of-choice if we would not > check in these files. Makes sense, thanks. The Rust helpers one may not be the end of the world in terms of code navigation (since people will use the Rust abstractions and nobody should call the helpers from C), but since it is just 1 more script in the list, I think it is best to keep it as it is. Cheers, Miguel