Re: [PATCH] drm/drm_exec: avoid indirect goto
Christian König <[email protected]>
| Newsgroups | dev.linux.lists.llvm,dev.linux.lists.oe-kbuild-all,org.freedesktop.lists.amd-gfx,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 7/7/26 13:43, Dave Airlie wrote: > On Tue, 7 Jul 2026 at 19:11, Christian König <[email protected]> wrote: >> >> Adding a few more people to comment and review. >> >> Thanks Mike for the pointers, going to add them to the patch before pushing it to drm-misc-fixes. >> >> @Thomas, Maxime, Simona, Dave can anybody give me an rb or comment? > > I don't like it, but I also don't think the thing it replaces was > spectacular, so until we can figure out a nicer way let's go with it, Yeah agree. C is just lacking the functionality to cleanly do this. > Like I was wondering if putting the label in a macro would make it > more explainable, but I don't think it would help much. I was playing with that idea as well, but then decided against it for the simple reason that a __label__ can eventually contain multiple labels unrelated to each other. > > Reviewed-by: Dave Airlie <[email protected]> Thanks, Christian. > > Dave.