Re: [PATCH v3 05/12] LoongArch: Fix EFI linking with -fdata-sections

George Guo <[email protected]>
Newsgroups dev.linux.lists.llvm,dev.linux.lists.loongarch,org.kernel.vger.linux-kernel,org.kernel.vger.live-patching
Message-ID <[email protected]>
Hi Joe,

> nit: s/func-fdata-sections/-fdata-sections
[...]
> Also the commit message says, "Make sure they get linked into
> .init.data," but should that read, "... into .init.bss"?

Yes to both. I'll fix the "func-fdata-sections" typo and change
".init.data" to ".init.bss" in the commit message -- the .init.bss.*
globs land in .init.bss, not .init.data.

> Both arch/arm64/kernel/vmlinux.lds.S and
> arch/loongarch/kernel/vmlinux.lds.S contain a "/* from the EFI stub */"
> comment documenting the wildcard.
[...]
> ^^ typo: I meant the riscv version as well

Will do -- I'll add the "/* from the EFI stub */" comment next to the
wildcard, matching arm64 and riscv.

Thanks,
George
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.