Re: [PATCH v3] ARM: imx: Fix suspend/resume crash with Clang CFI
Nick Desaulniers <[email protected]> Fri, 24 Jul 2026 13:49:23 -0700
| Newsgroups | dev.linux.lists.llvm,dev.linux.lists.imx,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel,org.kernel.vger.stable |
|---|---|
| Message-ID | <CAKwvOdnaOy-nyZ=8oLw4N-_hA9JZVdP2BhR8cweCAOhsy4VG6w@mail.gmail.com> |
On Fri, Jul 24, 2026 at 8:54 AM Sami Tolvanen <[email protected]> wrote: > > On Thu, Jul 23, 2026 at 12:56 PM Yo'av Moshe <[email protected]> wrote: > > > > On 2026-07-23 9:21 PM, Sami Tolvanen wrote: > > > What's the value for the __kcfi_typeid_imx6_suspend symbol in > > > vmlinux.o? I would expect the hash value to look a bit more random. > > Checking vmlinux.o with `llvm-readelf -s vmlinux.o` indeed shows: > > > > a488ebfc 0 NOTYPE WEAK DEFAULT ABS __kcfi_typeid_imx6_suspend > > OK, so the hashes should match. I can only assume that the hash prefix > doesn't end up getting copied to OCRAM for some reason then, or Yeah, Yo'av did you test further modifications that explicitly copy the hash prefix? I assumed Nathan's change _plus some additional tweak to copy not just imx6_suspend to OCRAM which I assume the code already does, but I would imagine you need another change to copy __kcfi_typeid_imx6_suspend into OCRAM just before the function. Was that tested? > perhaps the source of the copy operation doesn't have relocations > applied? Either way, if this turns out to be infeasible, I think the > __nocfi approach is reasonable in this case too. > > Sami -- Thanks, ~Nick Desaulniers