Re: [PATCH 1/4] tools/nolibc: evaluate syscall() arguments before the arch macros
Ammar Faizi <[email protected]> Mon, 27 Jul 2026 08:21:45 +0700
| Newsgroups | dev.linux.lists.llvm,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest |
|---|---|
| Message-ID | <CA+KFgX76tbg_LTh6-PO-zrmhWtrjP4y3u47s1wximVFUQKq=uA@mail.gmail.com> |
On Mon, Jul 27, 2026 at 3:16 AM Thomas Weißschuh wrote: > __auto_type is only supported from GCC 4.9. I think this is old enough, > but it should be mentioned at least. > We really should have a documented policy for that. I suggest using the Linux kernel's minimal requirements. It's GCC 8.1 or Clang 17.0.1. Ref: https://docs.kernel.org/process/changes.html What do you think? Should this be documented in nolibc.h as a comment? > I'd like to apply the same thing to the __nolibc_syscallN() > usage within nolibc itself. While today we seem not to have any > problematic cases, at least I was not aware of the issue and breakage > might creep in accidentally. We can problably rename the > architecture-specific macros to __nolibc_syscall_archN() > and make __nolibc_syscall() the properly evaluating wrapper. My current approach aims to make the changes less invasive (that is, I don't touch arch-specific code for this one problem). But if the introduction of __nolibc_syscall_archN() is preferred, let's go with that. For now, I will wait for more discussion on this before sending a revised version. -- Ammar Faizi