Re: [PATCH] mptcp: pm: Fix address ID overflow when all IDs are exhausted
kernel test robot <[email protected]>
| Newsgroups | dev.linux.lists.llvm,dev.linux.lists.mptcp,dev.linux.lists.oe-kbuild-all |
|---|---|
| Message-ID | <[email protected]> |
Hi luoqing, kernel test robot noticed the following build warnings: [auto build test WARNING on mptcp/export] [also build test WARNING on mptcp/export-net linus/master v7.2-rc6 next-20260806] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/luoqing/mptcp-pm-Fix-address-ID-overflow-when-all-IDs-are-exhausted/20260806-155815 base: https://github.com/multipath-tcp/mptcp_net-next.git export patch link: https://lore.kernel.org/r/20260714080356.805839-1-l1138897701%40163.com patch subject: [PATCH] mptcp: pm: Fix address ID overflow when all IDs are exhausted config: um-randconfig-002-20260807 (https://download.01.org/0day-ci/archive/20260807/[email protected]/config) compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project 12df34b8469b8095359de8c249cb1b2753fadeea) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260807/[email protected]/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <[email protected]> | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ All warnings (new ones prefixed by >>): In file included from net/mptcp/pm_kernel.c:9: In file included from include/net/netns/generic.h:11: In file included from include/net/net_namespace.h:44: In file included from include/linux/skbuff.h:17: In file included from include/linux/bvec.h:10: In file included from include/linux/highmem.h:12: In file included from include/linux/hardirq.h:11: In file included from arch/um/include/asm/hardirq.h:24: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:12: In file included from arch/um/include/asm/io.h:24: include/asm-generic/io.h:1209:55: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 1209 | return (port > MMIO_UPPER_LIMIT) ? NULL : PCI_IOBASE + port; | ~~~~~~~~~~ ^ >> net/mptcp/pm_kernel.c:798:3: warning: label followed by a declaration is a C23 extension [-Wc23-extensions] 798 | unsigned int id = find_next_zero_bit(pernet->id_bitmap, | ^ 2 warnings generated. vim +798 net/mptcp/pm_kernel.c 734 735 static int mptcp_pm_nl_append_new_local_addr(struct pm_nl_pernet *pernet, 736 struct mptcp_pm_addr_entry *entry, 737 bool replace) 738 { 739 struct mptcp_pm_addr_entry *cur, *del_entry = NULL; 740 int ret = -EINVAL; 741 u8 addr_max; 742 743 spin_lock_bh(&pernet->lock); 744 /* to keep the code simple, don't do IDR-like allocation for address ID, 745 * just bail when we exceed limits 746 */ 747 if (pernet->next_id == MPTCP_PM_MAX_ADDR_ID) 748 pernet->next_id = 1; 749 if (pernet->endpoints == MPTCP_PM_MAX_ADDR_ID) { 750 ret = -ERANGE; 751 goto out; 752 } 753 if (test_bit(entry->addr.id, pernet->id_bitmap)) { 754 ret = -EBUSY; 755 goto out; 756 } 757 758 /* do not insert duplicate address, differentiate on port only 759 * singled addresses 760 */ 761 if (!address_use_port(entry)) 762 entry->addr.port = 0; 763 list_for_each_entry(cur, &pernet->endp_list, list) { 764 if (mptcp_addresses_equal(&cur->addr, &entry->addr, 765 cur->addr.port || entry->addr.port)) { 766 /* allow replacing the exiting endpoint only if such 767 * endpoint is an implicit one and the user-space 768 * did not provide an endpoint id 769 */ 770 if (!(cur->flags & MPTCP_PM_ADDR_FLAG_IMPLICIT)) { 771 ret = -EEXIST; 772 goto out; 773 } 774 if (entry->addr.id) 775 goto out; 776 777 /* allow callers that only need to look up the local 778 * addr's id to skip replacement. This allows them to 779 * avoid calling synchronize_rcu in the packet recv 780 * path. 781 */ 782 if (!replace) { 783 kfree(entry); 784 ret = cur->addr.id; 785 goto out; 786 } 787 788 pernet->endpoints--; 789 entry->addr.id = cur->addr.id; 790 list_del_rcu(&cur->list); 791 del_entry = cur; 792 break; 793 } 794 } 795 796 if (!entry->addr.id) { 797 find_next: > 798 unsigned int id = find_next_zero_bit(pernet->id_bitmap, 799 MPTCP_PM_MAX_ADDR_ID + 1, 800 pernet->next_id); 801 if (id > MPTCP_PM_MAX_ADDR_ID) { 802 ret = -ENOSPC; 803 goto out; 804 } 805 entry->addr.id = id; 806 if (!entry->addr.id && pernet->next_id != 1) { 807 pernet->next_id = 1; 808 goto find_next; 809 } 810 } 811 812 if (!entry->addr.id) 813 goto out; 814 815 __set_bit(entry->addr.id, pernet->id_bitmap); 816 if (entry->addr.id > pernet->next_id) 817 pernet->next_id = entry->addr.id; 818 819 if (entry->flags & MPTCP_PM_ADDR_FLAG_SIGNAL) { 820 addr_max = pernet->endp_signal_max; 821 WRITE_ONCE(pernet->endp_signal_max, addr_max + 1); 822 } 823 if (entry->flags & MPTCP_PM_ADDR_FLAG_SUBFLOW) { 824 addr_max = pernet->endp_subflow_max; 825 WRITE_ONCE(pernet->endp_subflow_max, addr_max + 1); 826 } 827 if (entry->flags & MPTCP_PM_ADDR_FLAG_LAMINAR) { 828 addr_max = pernet->endp_laminar_max; 829 WRITE_ONCE(pernet->endp_laminar_max, addr_max + 1); 830 } 831 if (entry->flags & MPTCP_PM_ADDR_FLAG_FULLMESH) { 832 addr_max = pernet->endp_fullmesh_max; 833 WRITE_ONCE(pernet->endp_fullmesh_max, addr_max + 1); 834 } 835 836 pernet->endpoints++; 837 if (!entry->addr.port) 838 list_add_tail_rcu(&entry->list, &pernet->endp_list); 839 else 840 list_add_rcu(&entry->list, &pernet->endp_list); 841 ret = entry->addr.id; 842 843 out: 844 spin_unlock_bh(&pernet->lock); 845 846 /* just replaced an existing entry, free it */ 847 if (del_entry) { 848 synchronize_rcu(); 849 __mptcp_pm_release_addr_entry(del_entry); 850 } 851 return ret; 852 } 853 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki