Re: [PATCH] rust: uapi: replace direct asm-generic/ioctl.h include with linux/ioctl.h
Mukesh Kumar Chaurasiya <[email protected]>
| Newsgroups | dev.linux.lists.llvm,org.kernel.vger.linux-kernel,org.kernel.vger.rust-for-linux |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Aug 10, 2026 at 05:29:02PM +0200, Miguel Ojeda wrote: > On Sat, Aug 8, 2026 at 5:22 AM Mukesh Kumar Chaurasiya (IBM) > <[email protected]> wrote: > > > > uapi/asm-generic/ioctl.h: warning: '_IOC_SIZEBITS' macro redefined > > uapi/asm-generic/ioctl.h: warning: '_IOC_DIRBITS' macro redefined > > uapi/asm-generic/ioctl.h: warning: '_IOC_NONE' macro redefined > > uapi/asm-generic/ioctl.h: warning: '_IOC_WRITE' macro redefined > > Thanks for the patch! I can pick this one up. > > I am wondering: the quoted warnings were shortened intentionally, > right? i.e. I saw longer paths when I reproduced this. > > If so, then we could put the full ones (at least personally I prefer > that, even if it goes over the line length, because I want that it is > easy to search for, to avoid edit mistakes etc.) > Yeah, I intertionally trimmed it. I'll send out with the full path. > > Applies on linux-next. > > This would normally go below the `---` line, i.e. outside the commit > message (and ideally use `git format-patch --base` to provide the base > commit too). > Sure, i'll fix this and send out a new revision. Thanks, Mukesh > Thanks! > > Cheers, > Miguel