Re: [PATCH 1/5] Docs: changes.rst: rename file and references and add links
| Newsgroups | dev.linux.lists.llvm,org.kernel.vger.bpf,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel,org.kernel.vger.rust-for-linux,org.kernel.vger.workflows |
|---|---|
| Message-ID | <1eab9fe487b6cba29d405e83619885945bf1143b42cc556aaf282abd0c5ad46a@mail.kernel.org> |
> The current name does not reflect the content of the file, the new name > does so. With the links legacy references should continue to work. > > Change name to software-requirements.rst > Change names in Doc/translations/* > Add link Doc/process/changes.rst to software-version.rst. > Add link Doc/Changes to software-version.rst. > Add links in Doc/translations/* > Change changes.rst to software-version.rst inChange changes.rst to software-version.rst in The commit message uses the wrong filename in several places. The patch renames the document to "software-requirements.rst", but the message says "software-version.rst" here: Add link Doc/process/changes.rst to software-version.rst. Add link Doc/Changes to software-version.rst. Should these say "software-requirements.rst" instead? The message also has a duplicated line fragment: Change changes.rst to software-version.rst inChange changes.rst to software-version.rst in Was this a copy-paste error? [ ... ] > diff --git a/Documentation/translations/zh_TW/admin-guide/README.rst b/Documentation/translations/zh_TW/admin-guide/README.rst > index 4b701cc2860e6..ba18a01639d2a 100644 > --- a/Documentation/translations/zh_TW/admin-guide/README.rst > +++ b/Documentation/translations/zh_TW/admin-guide/README.rst [ ... ] > @@ -107,7 +107,7 @@ > > 編譯和運行6.x內核需要各種軟件包的最新版本。請參考 > - :ref:`Documentation/process/changes.rst <changes>` > + :ref:`Documentation/process/software-requirements.rst <software-requirements.rst>` > 來了解最低版本要求以及如何升級軟件包。請注意,使用過舊版本的這些包可能會 Does the label need the .rst extension? Sphinx :ref: labels are identifiers, not filenames. Line 58 and line 231 in this same file use <software-requirements> without the extension, and the corresponding zh_CN file also uses <software-requirements>. This produces "undefined label: software-requirements.rst" during the build. The same .rst-in-label issue appears in Documentation/translations/ja_JP/process/howto.rst:108. --- AI reviewed your patch. Please fix the bug or email reply why it's not a bug. See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md CI run summary: https://github.com/kernel-patches/bpf/actions/runs/31597231148