Re: [PATCH] scsi: ibmvfc: Fix use of uninitialized rport in ibmvfc_do_work()
Tyrel Datwyler <[email protected]>
| Newsgroups | dev.linux.lists.llvm,org.kernel.vger.linux-kernel,org.kernel.vger.linux-scsi,org.ozlabs.lists.linuxppc-dev |
|---|---|
| Message-ID | <[email protected]> |
On 8/17/26 12:04 PM, Nathan Chancellor wrote:
> After commit 696d1cc2aaa2 ("scsi: ibmvfc: process NVMe/FC rports in work
> thread"), clang warns (or errors with CONFIG_WERROR=y / W=e):
>
> drivers/scsi/ibmvscsi/ibmvfc-core.c:6154:15: error: variable 'rport' is uninitialized when used here [-Werror,-Wuninitialized]
> 6154 | } else if (rport && tgt->action == IBMVFC_TGT_ACTION_DEL_AND_LOGOUT_RPORT) {
> | ^~~~~
>
> The check for rport is unnecessary in this block, it was accidentally
> included from copying and pasting. Remove it to clear up the warning.
>
> Fixes: 696d1cc2aaa2 ("scsi: ibmvfc: process NVMe/FC rports in work thread")
> Suggested-by: Tyrel Datwyler <[email protected]>
> Link: https://lore.kernel.org/[email protected]/
> Signed-off-by: Nathan Chancellor <[email protected]>
> ---
Acked-by: Tyrel Datwyler <[email protected]>