Re: [patch 04/18] loongarch/syscall: Use syscall_enter_from_user_mode_randomize_stack()
Mukesh Kumar Chaurasiya <[email protected]>
| Newsgroups | dev.linux.lists.loongarch,org.infradead.lists.linux-riscv,org.infradead.lists.linux-snps-arc,org.infradead.lists.linux-um,org.kernel.vger.linux-alpha,org.kernel.vger.linux-arch,org.kernel.vger.linux-csky,org.kernel.vger.linux-doc,org.kernel.vger.linux-hexagon,org.kernel.vger.linux-kernel,org.kernel.vger.linux-m68k,org.kernel.vger.linux-mips,org.kernel.vger.linux-openrisc,org.kernel.vger.linux-parisc,org.kernel.vger.linux-s390,org.kernel.vger.linux-sh,org.kernel.vger.sparclinux,org.ozlabs.lists.linuxppc-dev |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Jul 07, 2026 at 09:06:11PM +0200, Thomas Gleixner wrote: > syscall_enter_from_user_mode_randomize_stack() replaces > syscall_enter_from_user_mode() and the subsequent invocation of > add_random_kstack_offset(). > > The advantage is that it applies the stack randomization right after > enter_from_user_mode() and thereby avoids the overhead of get/put_cpu_var() > as that code is invoked with interrupts disabled. > > No functional change. > > Signed-off-by: Thomas Gleixner <[email protected]> > Cc: Huacai Chen <[email protected]> > Cc: [email protected] > --- > arch/loongarch/kernel/syscall.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > --- a/arch/loongarch/kernel/syscall.c > +++ b/arch/loongarch/kernel/syscall.c > @@ -11,7 +11,6 @@ > #include <linux/linkage.h> > #include <linux/nospec.h> > #include <linux/objtool.h> > -#include <linux/randomize_kstack.h> > #include <linux/syscalls.h> > #include <linux/unistd.h> > > @@ -70,9 +69,7 @@ void noinstr __no_stack_protector do_sys > regs->orig_a0 = regs->regs[4]; > regs->regs[4] = -ENOSYS; > > - nr = syscall_enter_from_user_mode(regs, nr); > - > - add_random_kstack_offset(); > + nr = syscall_enter_from_user_mode_randomize_stack(regs, nr); > > if (nr < NR_syscalls) { > syscall_fn = sys_call_table[array_index_nospec(nr, NR_syscalls)]; > > Reviewed-by: Mukesh Kumar Chaurasiya (IBM) <[email protected]> > _______________________________________________ > linux-snps-arc mailing list > [email protected] > http://lists.infradead.org/mailman/listinfo/linux-snps-arc