[PATCH 11/14] Add lvm_vg_get_property() generic vg property function.
Dave Wysochanski <[email protected]>
| Newsgroups | dev.linux.lists.lvm-devel |
|---|---|
| Message-ID | <1287152329.27666.2.camel@f12-work> |
On Tue, 2010-10-12 at 13:05 +0200, Petr Rockai wrote: > Zdenek Kabelac <[email protected]> writes: > >> + struct lvm_property_type prop; > >> + > >> + strncpy(prop.id, name, LVM_PROPERTY_NAME_LEN); > > > > Hmmm why doing a copy here instead of passing/assigning 'name' ptr somewhere? > > Because lvm_property_type says: char id[LVM_PROPERTY_NAME_LEN]; > > Yours, > Petr. > Thanks both of you for the feedback. I am reworking this based on all your comments and will re-post soon.