LVM2/lib metadata/lv.c metadata/lv.h report/pr ...
Zdenek Kabelac <[email protected]>
| Newsgroups | dev.linux.lists.lvm-devel |
|---|---|
| Message-ID | <[email protected]> |
Dne 12.10.2010 18:12, wysochanski at sourceware.org napsal(a):
> CVSROOT: /cvs/lvm2
> Module name: LVM2
> Changes by: wysochanski at sourceware.org 2010-10-12 16:12:34
>
> Modified files:
> lib/metadata : lv.c lv.h
> lib/report : properties.c report.c
>
> Log message:
> Refactor and add code for (lv) 'lv_kernel_{major|minor}' get functions.
>
> Signed-off-by: Dave Wysochanski <[email protected]>
> Reviewed-By: Petr Rockai <[email protected]>
>
> +int lv_kernel_minor(const struct logical_volume *lv)
> +{
> + struct lvinfo info;
>
I think for cases like this one - where the return value is different from
common practice in lvm codebase we should add some doxygen comments - so it's
clear that -1 is return value in this function.
Zdenek