Re: [PATCH] mailbox: Clean up the usage of mailbox_client.h
Peng Fan <[email protected]> Wed, 28 Jan 2026 15:50:23 +0800
| Newsgroups | dev.linux.lists.mailbox,org.kernel.vger.linux-acpi,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <aXm/v5KWJf3k7V6a@shlinux89> |
On Tue, Jan 27, 2026 at 04:00:39PM +0000, Sudeep Holla wrote: >On Tue, Jan 27, 2026 at 02:47:33PM +0000, Peng Fan wrote: [...] >> > > > #include <linux/mailbox_controller.h> -#include >> > > > <linux/mailbox_client.h> #include <linux/io-64-nonatomic-lo-hi.h> >> > > > #include <acpi/pcc.h> >> > > > >> > > >> > > There is a call to mbox_bind_client() in pcc.c that is declared in >> > > linux/mailbox_client.h >> > >> > Thanks for raising this. >> >> Check again. >> >> include/acpi/pcc.h includes mailbox_client.h >> > >I see, I missed that. I’m fine with removing it, but the commit message >doesn’t really apply here since it’s getting included anyway. I don’t see >much point in removing it, but I’m fine either way. I will remove the change to pcc.c in V2, since this driver uses mbox_bind_client(). Thanks, Peng >-- >Regards, >Sudeep >