Re: [PATCH net-next v2 4/8] net: phy: add X-Powers AC200 EPHY control driver

> The AC200 Fast Ethernet PHY needs package registers in the parent I2C
> regmap to be configured before its Clause 22 endpoint becomes usable.
> 
> Add a control driver which obtains the calibration value, applies the
> vendor offset, selects the documented 24 or 27 MHz input clock, programs
> the link PHY address and performs the required reset, clock and shutdown
> sequence. Use the optional SoC SID cell when supplied and otherwise read
> the AC200's internal calibration eFuse.
> 
> Early PHY creation occurs before a MAC has attached, so use reset-default
> MII initially. A separate operation later applies phydev->interface; when
> the block is already powered it changes only RMII_SEL before the normal
> PHY soft reset.
> 
> Expose serialized, idempotent power and interface operations to the
> common PHY driver. Enable only the MII I/O pads in this basic driver;
> dedicated LED outputs remain disabled until a later LED patch describes
> and manages them.
> 
> Signed-off-by: James Hilliard <[email protected]>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4