Re: [PATCH net-next v19 03/10] dt-bindings: mfd: Document support for Airoha AN8855 Switch SoC
Rob Herring <[email protected]>
| Newsgroups | dev.linux.lists.mfd,dev.linux.lists.sashiko-reviews,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Jul 29, 2026 at 05:16:35PM +0000, [email protected] wrote: > Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider: If you want to make maintainers happy, reply to sashiko reports on with what you think are valid or not valid issues. > - [Low] The `reset-gpios` property is defined as `true` without a `maxItems` constraint. Not an issue. > - [Low] The `mdio` child node property is missing the `type: object` declaration. Not an issue because we implicitly add one IIRC, but you are inconsistent with using 'type: object' on child nodes. > - [Low] The example includes a DT binding header for GPIO flags but uses a magic number instead of the appropriate macro. Fix this. Rob