Re: [PATCH v7 2/2] mfd: ac200: Add X-Powers AC200 support
| Newsgroups | dev.linux.lists.mfd,dev.linux.lists.linux-sunxi,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
> The X-Powers AC200 is a mixed-signal companion IC with a paged register > map accessed over I2C. > > Enable the shared input clock and prevent its rate from changing. Match > the vendor driver's 40 ms wait before the first register access, > initialize the paged regmap, report the chip and package revision, and > apply common reset. > > The Ethernet PHY link endpoint is independently enumerated on its MDIO > bus rather than created as an MFD platform child. Keep the regmap attached > to the AC200 I2C device so a separately enumerated function can resolve > that device, establish its required lifetime relationship and retrieve > the regmap from the provider. > > Cache only the common page selector. Individual functions can reset > independently and invalidate their other registers without regmap's > knowledge, so leave all functional registers volatile. > > Reset the chip during managed teardown and system shutdown. > > Signed-off-by: James Hilliard <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2