Re: [PATCH RESEND v6 4/5] mfd: axp20x: Add support for AXP318W PMIC
Lee Jones <[email protected]>
| Newsgroups | dev.linux.lists.mfd,dev.linux.lists.sashiko-reviews,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
On Thu, 13 Aug 2026, Jerome Brunet wrote: > On sam. 12 janv. 2008 at 23:40, [email protected] wrote: > > > Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: > > - [High] The corresponding regulator driver lacks support for `AXP318_ID`, causing the `axp20x-regulator` child device probe to fail. > > Funny sashiko did not pick up on this when v6 was first sent. This is an > ordering problem. The regulator part should be applied before the mfd > one. > > I could reorder here but there is not much point since the 2 changes will > land in different subsystems but it does bring a valid question: > > Lee, Mark, are you OK with picking the patches indended for your > subsystem or would you prefer that I split the series, regulator on one > side, mfd on the other (with a dep on the regulator one, of course) ? Does this break existing devices or simply delay support for this new one? -- Lee Jones