Re: [PATCH v24 04/12] mfd: psci-mfd: Add PSCI MFD driver for cpuidle-psci-domain cell
Bartosz Golaszewski <[email protected]>
| Newsgroups | dev.linux.lists.mfd,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pm |
|---|---|
| Message-ID | <CAMRc=MdA_zM_pHCmk7dd7kosqvNmFgA+iXvHS4qpNs9bdsUMCg@mail.gmail.com> |
On Thu, 13 Aug 2026 14:38:41 +0200, Lee Jones <[email protected]> said: > On Mon, 03 Aug 2026, Shivendra Pratap wrote: > >> PSCI has multiple kernel consumers, such as cpuidle-psci-domain. >> Currently, both the PSCI core driver and cpuidle-psci-domain bind >> directly to the same PSCI node "arm,psci-1.0". Additional consumers, if >> introduced, would also need to bind in the same way, leading to several >> drivers attached to a single device node. >> >> Introduce a PSCI MFD driver that binds to "arm,psci-1.0" and registers >> PSCI child cells. As the first user, register cpuidle-psci-domain as a >> child cell. >> >> Update cpuidle-psci-domain to probe as an MFD child and use the parent >> PSCI node for power-domain traversal. >> >> Suggested-by: Bartosz Golaszewski <[email protected]> >> Reviewed-by: Bartosz Golaszewski <[email protected]> >> Signed-off-by: Shivendra Pratap <[email protected]> >> --- >> MAINTAINERS | 1 + >> drivers/cpuidle/Kconfig.arm | 1 + >> drivers/cpuidle/cpuidle-psci-domain.c | 9 +------- >> drivers/mfd/Kconfig | 12 ++++++++++ >> drivers/mfd/Makefile | 2 ++ >> drivers/mfd/psci-mfd.c | 43 +++++++++++++++++++++++++++++++++++ > > We don't usually allow the use of the term MFD in devices. > > What does this do? Is it a mux? psci-mux? > > If not, think about what it is and call it that instead. > My two cents: I'd call it drivers/mfd/arm-psci.c Bartosz