Re: [PATCH] dt-bindings: mfd: ti,keystone-devctrl: Convert to DT schema
Bhargav Joshi <[email protected]>
| Newsgroups | dev.linux.lists.mfd,dev.linux.lists.sashiko-reviews,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <CAOWyW_7NL1GeWCTu5LED4avsRLMOHMs1kVxGN0r+MxMhHSj_AA@mail.gmail.com> |
On Fri, Aug 14, 2026 at 12:18 PM Krzysztof Kozlowski <[email protected]> wrote: > > On Thu, Aug 13, 2026 at 10:24:12PM +0530, Bhargav Joshi wrote: > > On Thu, Aug 13, 2026 at 10:11 PM <[email protected]> wrote: > > > > > > Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: > > > - [Medium] The schema enforces non-compliant, legacy device tree node names (containing underscores) for child nodes via `patternProperties`, blocking the use of standard generic names and contradicting the commit message. > > Yes nodes with underscores are kept not to break older dts/dtsi files > > which uses underscores > > No, you made them ABI now without explanation why this is needed. I will fix dtsi instead of keeping incorrect child names in binding in V2 > Best Regards, Bhargav