Re: [PATCH v5 11/12] arm64: ambarella: add ARCH_AMBARELLA and CV75 EVK DT
| Newsgroups | dev.linux.lists.mfd,org.kernel.vger.linux-clk,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] ARCH_AMBARELLA incorrectly selects ARM32-specific config symbols ARM_PSCI and HAVE_ARM_ARCH_TIMER. -- --- Patch [11]: [PATCH v5 11/12] arm64: ambarella: add ARCH_AMBARELLA and CV75 EVK DT --- commit 6d6514ac64e30fc6200e81fab461334ff299c3d2 Author: Long Zhao <[email protected]> arm64: ambarella: add ARCH_AMBARELLA and CV75 EVK DT This commit enables the ARCH_AMBARELLA platform in the arm64 Kconfig and adds a minimal device tree for the CV75 SoC and EVK board for console bring-up. > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index d2acfac730037..cb05eff267a84 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -26,6 +26,14 @@ config ARCH_SUNXI > help > This enables support for Allwinner sunxi based SoCs like the A64. > > +config ARCH_AMBARELLA > + bool "Ambarella SoC family" > + select ARM_PSCI > + select HAVE_ARM_ARCH_TIMER [Severity: Low] Is it necessary to select ARM_PSCI and HAVE_ARM_ARCH_TIMER for ARCH_AMBARELLA in arch/arm64/Kconfig.platforms? These config symbols appear to be ARM32-specific and do not exist in the arm64 Kconfig tree. > + select PINCTRL > + help > + This enables support for the ARM64 based Ambarella SoCs like CV75. > + > config ARCH_ALPINE -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=11