Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The devicetree binding exposes `avddldo-supply` as a configurable property, but the description explicitly notes it is an 'internal supply derived from vsys'. Devicetree is intended to describe board-level hardware configurations (like external pin connections or PCB routing). Hardwired internal IC routing is a static property of the chip and should be modeled internally within the driver, rather than exposed as a configurable devicetree property.
--
--- Patch [3]: [PATCH v9 3/9] regulator: dt-bindings: Add MediaTek MT6392 PMIC ---
commit 2d8836e1efcb0c65952c3a56b41f16c4a50e3f1e
Author: Luca Leonardo Scorcia <[email protected]>
regulator: dt-bindings: Add MediaTek MT6392 PMIC
This commit adds devicetree bindings for the voltage regulators found in
the MediaTek MT6392 PMIC. It describes the buck converters, LDOs, and their
allowed modes for board designs using MT8516/MT8167 SoCs.
> diff --git a/Documentation/devicetree/bindings/regulator/mediatek,mt6392-regulator.yaml b/Documentation/devicetree/bindings/regulator/mediatek,mt6392-regulator.yaml
> new file mode 100644
> index 0000000000000..d74721d8f2ffc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt6392-regulator.yaml
[ ... ]
> @@ -21,12 +21,15 @@ properties:
> vproc-supply:
> description: Supply for buck regulator vproc
> vcore-supply:
> description: Supply for buck regulator vcore
> vsys-supply:
> description: Supply for buck regulator vsys
> avddldo-supply:
> description:
> Supply for AVDD LDOs (vm, vio18, vcn18, vcamd, vcamio). According to the data sheet
> this is an internal supply derived from vsys.
[Severity: Low]
Since this is an internal supply derived from vsys, should it be exposed
as a configurable devicetree property?
Devicetree is typically intended to describe board-level hardware
configurations like external pin connections. Since the hardwired internal
IC routing is a static property of the chip, would it be better to model
this internally within the driver rather than exposing it as a configurable
devicetree property?
> ldo1-supply:
> description: Supply for LDOs group 1 (vaud28, vxo22, vaud22, vadc18, vcama, vrtc)
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.