Re: [PATCH v2 16/23] mfd: Use named initializers for platform_device_id array
Linus Walleij <[email protected]>
| Newsgroups | dev.linux.lists.mfd,dev.linux.lists.chrome-platform,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-mediatek,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CAD++jL=5A+qcU4FQYzBPOVK8t+9xPRX5p9ycijkwOa4Oh1XJcQ@mail.gmail.com> |
On Wed, Jul 8, 2026 at 1:17 PM Uwe Kleine-König (The Capable Hub) <[email protected]> wrote: > While being less compact, using named initializers allows to more easily > see which members of the structs are assigned which value without having > to lookup the declaration of the struct. And it's also more robust > against changes to the struct definition. > > The mentioned robustness is relevant for a planned change to struct > platform_device_id that replaces .driver_data by an anonymous union. > > This patch doesn't modify the compiled arrays, only their representation > in source form benefits. > > Also drop a tailing comma after a list terminator to match the common > style for these device-id arrays. > > Signed-off-by: Uwe Kleine-König (The Capable Hub) <[email protected]> Reviewed-by: Linus Walleij <[email protected]> Yours, Linus Walleij