Re: [PATCH 11/16] ARM: dts: omap3-pandora-common: Enable audio in/out (mcbsp4/2)

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] Missing Sound Card devicetree node leaves audio broken.
- [Medium] Missing Pin Multiplexing for McBSP nodes.
--

--- Patch [11]: [PATCH 11/16] ARM: dts: omap3-pandora-common: Enable audio in/out (mcbsp4/2) ---
commit e4ecb9f743bc9100e161520f1482dafaecae52b7
Author: Stefan Leichter <[email protected]>

ARM: dts: omap3-pandora-common: Enable audio in/out (mcbsp4/2)

This commit enables the mcbsp2 and mcbsp4 nodes in the omap3-pandora-common
device tree to support audio.

> diff --git a/arch/arm/boot/dts/ti/omap/omap3-pandora-common.dtsi b/arch/arm/boot/dts/ti/omap/omap3-pandora-common.dtsi
> index b4acab1625212..5907b2455f75b 100644
> --- a/arch/arm/boot/dts/ti/omap/omap3-pandora-common.dtsi
> +++ b/arch/arm/boot/dts/ti/omap/omap3-pandora-common.dtsi
> @@ -716,6 +716,7 @@ &mcbsp1 {
>  
>  /* audio DAC */
>  &mcbsp2 {
> +	status = "okay";

[Severity: High]
Is the audio hardware left non-functional because the sound card devicetree
node is missing?

While this enables the McBSP nodes, the machine sound driver itself is never
instantiated because its device node (matching openpandora,omap3pandora-sound)
is missing.

[Severity: Medium]
Are the required pinctrl configurations missing for this node?

It is a standard devicetree requirement on OMAP3 to define
pinctrl-names = "default"; and pinctrl-0 = <...>; properties for enabled
peripherals so that the kernel explicitly claims and configures the pins
independent of the bootloader state.

>  };
>  
>  /* bluetooth */
> @@ -724,6 +725,7 @@ &mcbsp3 {
>  
>  /* to twl4030*/
>  &mcbsp4 {
> +	status = "okay";

[Severity: Medium]
Should this node also include pinctrl configurations to ensure the kernel
explicitly configures the pins independent of the bootloader state?

>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=11