Re: [PATCH v2 3/8] Add Advantech EIO Hardware Monitor driver
Guenter Roeck <[email protected]>
| Newsgroups | dev.linux.lists.mfd,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-fbdev,org.kernel.vger.linux-gpio,org.kernel.vger.linux-hwmon,org.kernel.vger.linux-i2c,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pm,org.kernel.vger.linux-watchdog |
|---|---|
| Message-ID | <[email protected]> |
On 7/14/26 08:54, Ramiro Oliveira wrote: > This driver controls the Hardware Monitor block of the Advantech EIO chip. > > There is a separate driver for the thermal device driver > since it's a use case we support currently, but if it's > really necessary we can move it to the same driver. > > Signed-off-by: Ramiro Oliveira <[email protected]> Normally there would be a hwmon driver instantiating the thermal zone(s) using HWMON_C_REGISTER_TZ. If the driver actively controls thermal zones since it also handles fans, that would be instantiated from the hwmon driver. Since you have both thermal temperature and thermal fan drivers, I am very concerned that there is functionality overlap andor even conflicts. You should drop this driver and configure the thermal temperature driver to instantiate a hwmon device from it if so desired. Thanks, Guenter