Re: [PATCH 3/3] mfd: cs42l43: Add support for new cs42l44 variant

On Thu, Jul 16, 2026 at 05:08:14PM +0100, Lee Jones wrote:
> On Thu, 16 Jul 2026, Charles Keepax wrote:
> 
> > On Thu, Jul 16, 2026 at 04:14:37PM +0100, Lee Jones wrote:
> > > On Wed, 08 Jul 2026, Charles Keepax wrote:
> > > > The cs42l44 is a cost optimised variant of cs42l43b. Add basic support
> > > > for this new device.
> > > > 
> > > > Signed-off-by: Charles Keepax <[email protected]>
> > > > ---
> > > > +	case CS42L44_DEVID_VAL:
> > > > +		valid_id = (cs42l43->variant_id == CS42L43B_DEVID_VAL);
> > > >  		break;
> > > >  	default:
> > > >  		dev_err(cs42l43->dev, "Unrecognised devid: 0x%06x\n", devid);
> > > >  		goto err;
> > > >  	}
> > > >  
> > > > +	if (!valid_id) {
> > > 
> > > How is this nor handled in the default branch?
> > 
> > The default case ends in goto err; so this doesn't run in that
> > case.
> 
> So are there 'case's that do not populate valid_id?

No, all the cases populate valid_id.

The switch is basically checking if the chip ID matches the ID
that was given in ACPI/DT, so I would also expect this to
always be the case.

Thanks,
Charles