Re: [PATCH v1 1/1] gpio: legacy: Kill gpio_set_value_cansleep()
Andy Shevchenko <[email protected]>
| Newsgroups | dev.linux.lists.mfd,dev.linux.lists.sashiko-reviews |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo |
| Message-ID | <[email protected]> |
On Wed, Jul 15, 2026 at 07:41:02PM +0000, [email protected] wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [Low] Removal of `gpio_set_value_cansleep()` breaks the build for `drivers/mfd/si476x-i2c.c`. ... > [Severity: Low] > Does removing this function break the build for drivers/mfd/si476x-i2c.c? Yes, and there is a comment to apply this via MFD tree. Did you read that? > There appear to be active callers of gpio_set_value_cansleep() that will > cause implicit declaration errors when CONFIG_MFD_SI476X_CORE is enabled. -- With Best Regards, Andy Shevchenko