Re: [PATCH v2 08/10] arm64: dts: qcom: pmih0108-kaanapali: Enable BCL sensor node

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The BCL hardware monitor node is added to the `pmih0108-kaanapali.dtsi` variant but omitted from the base `pmih0108.dtsi` PMIC definition file.
--

--- Patch [8]: [PATCH v2 08/10] arm64: dts: qcom: pmih0108-kaanapali: Enable BCL sensor node ---
commit f763d763d5dd94fa5bdd7efdfec8819781ecf122
Author: Manaf Meethalavalappu Pallikunhi <[email protected]>
arm64: dts: qcom: pmih0108-kaanapali: Enable BCL sensor node

This commit adds the Battery Current Limiting (BCL) hardware monitor node
for the pmih0108 PMIC in the pmih0108-kaanapali.dtsi file. This enables
battery voltage and current monitoring with hardware interrupts.

> diff --git a/arch/arm64/boot/dts/qcom/pmih0108-kaanapali.dtsi b/arch/arm64/boot/dts/qcom/pmih0108-kaanapali.dtsi
> index b73b0e82c3d31..67b77272b0cf9 100644
> --- a/arch/arm64/boot/dts/qcom/pmih0108-kaanapali.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmih0108-kaanapali.dtsi
> @@ -49,6 +49,15 @@ pmih0108_e1_temp_alarm: temp-alarm@a00 {
>  			#thermal-sensor-cells = <0>;
>  		};
>  
> +		sensor@4700 {
> +			compatible = "qcom,pmih0108-bcl";
> +			reg = <0x4700>;
> +			interrupts = <0x7 0x47 0x0 IRQ_TYPE_EDGE_RISING>,
> +				     <0x7 0x47 0x1 IRQ_TYPE_EDGE_RISING>;
> +			interrupt-names = "max-min",
> +					  "critical";
> +		};
> +

[Severity: Medium]
Should this BCL sensor node also be added to the base pmih0108.dtsi PMIC
definition file?

It appears the node is being added to the pmih0108-kaanapali.dtsi variant,
but omitting it from the base pmih0108.dtsi might prevent boards using the
standard PMIC from receiving battery current and voltage hardware interrupts.

Without BCL monitoring, those systems might not be able to proactively
throttle the SoC during high current draw or low voltage, which could
potentially lead to unexpected shutdowns under heavy load.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=8