Re: [PATCH v3 1/2] dt-bindings: thermal: Add Qualcomm MBG thermal monitor support

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The generic `^temperature-sensor@[0-9a-f]+$` node name pattern in the SPMI PMIC schema is exclusively bound to the `qcom,pm8775-mbg-tm` schema, which causes validation failures for other thermal peripherals (like `qcom,spmi-temp-alarm`) that use the standard `temperature-sensor` generic node name.
--

--- Patch [1]: [PATCH v3 1/2] dt-bindings: thermal: Add Qualcomm MBG thermal monitor support ---
commit 0d6b48e0b8d3e826b0476c17d69e98ce1c6de883
Author: Satya Priya Kakitapalli <[email protected]>

dt-bindings: thermal: Add Qualcomm MBG thermal monitor support

This commit adds device tree bindings for the Qualcomm Master Bandgap (MBG)
temperature alarm peripheral found on the PM8775 PMIC. It supports both hot
and cold threshold monitoring with interrupt status reported over SPMI.

> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> index 809be2756a0c0..bd77cb7173e26 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> @@ -194,6 +194,10 @@ patternProperties:
>      type: object
>      $ref: /schemas/thermal/qcom,spmi-temp-alarm.yaml#
>  
> +  "^temperature-sensor@[0-9a-f]+$":
> +    type: object
> +    $ref: /schemas/thermal/qcom,pm8775-mbg-tm.yaml#

[Severity: Medium]
Will this exclusive mapping cause validation failures for other thermal
peripherals?

If a device tree uses a standard temperature-sensor@... node name with a
different compatible string (such as qcom,spmi-temp-alarm) under a
qcom,spmi-pmic node, it seems it would incorrectly fail dtbs_check validation
because it is strictly bound to qcom,pm8775-mbg-tm.yaml here.

Should this pattern property use a oneOf block to permit any supported
thermal sensor schema, rather than binding the generic node name strictly
to the MBG schema?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1