Re: [PATCH v2 01/10] dt-bindings: hwmon: Describe Qualcomm BCL hardware

Krzysztof Kozlowski <[email protected]> Thu, 23 Jul 2026 10:11:33 +0200

Newsgroups	dev.linux.lists.mfd,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-hwmon,org.kernel.vger.linux-kernel
Message-ID	<20260723-radiant-scorpion-of-hurricane-cbed57@quoll>

On Wed, Jul 22, 2026 at 12:00:06AM +0530, Manaf Meethalavalappu Pallikunhi wrote:
> +properties:
> +  compatible:
> +    enum:
> +      - qcom,pm7250b-bcl
> +      - qcom,pm8350c-bcl
> +      - qcom,pm8550-bcl
> +      - qcom,pmh0101-bcl
> +      - qcom,pmih0108-bcl
> +      - qcom,smb2360-bcl
> +      - qcom,smb2370-bcl
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 2
> +
> +  interrupt-names:
> +    items:
> +      - const: max-min
> +      - const: critical
> +

Binding looks in general ok, but feels incomplete. If this is battery
limiting hardware, does it actually need any battery data through
monitored-battery property?

Best regards,
Krzysztof