Re: [PATCH RFC v3 7/7] mfd: ls2kbmc: Capture the reset event of BMC through GPIO

Hi,

> 2026年7月23日 19:29，Lee Jones <[email protected]> 写道：
> 
> On Thu, 09 Jul 2026, [email protected] wrote:
> 
>> Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
>> 
>> New issues:
>> - [High] Unprotected access to `gpio_chip` without a NULL check leads to a potential NULL pointer dereference or use-after-free.
>> - [Medium] The ACPI memory resource search for the GPIO controller only checks the first memory descriptor, ignoring any subsequent ones.
> 
> Looks like there are a few of these to consider.

Many thanks for your response. I was preparing a v4 to fix the first issue
found by the bot. However, I believe that the second issue is false positive,
since the memory descriptors (if more than one) in _CRS are ordered and the
position is meaningful for the driver. As a result, only checking the first
descriptor is acceptable.

> 
> I'm unmarking this for review for now.

I still want review for other improvement suggestions. Thanks in advance.

Cheers,

Miao Wang