Re: [PATCH v8 11/12] reset: zte: Add a zx297520v3 reset driver
[email protected] Mon, 27 Jul 2026 19:59:47 +0000
| Newsgroups | dev.linux.lists.mfd,org.infradead.lists.linux-phy,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The Kconfig entry selects MFD_SYSCON without inheriting its HAS_IOMEM dependency, risking an unmet direct dependency warning. -- --- Patch [11]: [PATCH v8 11/12] reset: zte: Add a zx297520v3 reset driver --- commit 12743a130823c55b091e1dd6972558ed49c19d61 Author: Stefan Dösinger <[email protected]> reset: zte: Add a zx297520v3 reset driver This commit adds the reset driver for ZTE zx297520v3 SoCs to drive the MFD child devices created by the zte-zx297520v3-crm driver. > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig > index d009eb0849a3b..97f41574d81d5 100644 > --- a/drivers/reset/Kconfig > +++ b/drivers/reset/Kconfig [ ... ] > +config RESET_ZTE_ZX297520V3 > + tristate "ZTE zx297520v3 Reset Driver" > + depends on MFD_ZTE_ZX297520V3_CRM || COMPILE_TEST > + default SOC_ZX297520V3 > + select MFD_SYSCON [Severity: Medium] Could this select statement trigger an unmet direct dependency warning? Since this driver can be built with COMPILE_TEST, it might be compiled on architectures like UML that do not enable HAS_IOMEM. MFD_SYSCON requires HAS_IOMEM, so selecting it here without inheriting the HAS_IOMEM dependency can cause Kconfig warnings and potential build failures. Would it be better to add a dependency on HAS_IOMEM? -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=11