Re: [PATCH RFC v3 7/7] mfd: ls2kbmc: Capture the reset event of BMC through GPIO

Hi, Jones

> 2026=E5=B9=B47=E6=9C=8826=E6=97=A5 05:10=EF=BC=8CLee Jones =
<[email protected]> =E5=86=99=E9=81=93=EF=BC=9A
>=20
> On Thu, 23 Jul 2026, Miao Wang wrote:
>=20
>> Hi,
>>=20
>>> 2026=E5=B9=B47=E6=9C=8823=E6=97=A5 21:11=EF=BC=8CLee Jones =
<[email protected]> =E5=86=99=E9=81=93=EF=BC=9A
>>>=20
>>> On Thu, 23 Jul 2026, Miao Wang wrote:
>>>=20
>>>> Hi,
>>>>=20
>>>>> 2026=E5=B9=B47=E6=9C=8823=E6=97=A5 19:29=EF=BC=8CLee Jones =
<[email protected]> =E5=86=99=E9=81=93=EF=BC=9A
>>>>>=20
>>>>> On Thu, 09 Jul 2026, [email protected] wrote:
>>>>>=20
>>>>>> Thank you for your contribution! Sashiko AI review found 3 =
potential issue(s) to consider:
>>>>>>=20
>>>>>> New issues:
>>>>>> - [High] Unprotected access to `gpio_chip` without a NULL check =
leads to a potential NULL pointer dereference or use-after-free.
>>>>>> - [Medium] The ACPI memory resource search for the GPIO =
controller only checks the first memory descriptor, ignoring any =
subsequent ones.
>>>>>=20
>>>>> Looks like there are a few of these to consider.
>>>>=20
>>>> Many thanks for your response. I was preparing a v4 to fix the =
first issue
>>>> found by the bot. However, I believe that the second issue is false =
positive,
>>>> since the memory descriptors (if more than one) in _CRS are ordered =
and the
>>>> position is meaningful for the driver. As a result, only checking =
the first
>>>> descriptor is acceptable.
>>>>=20
>>>>>=20
>>>>> I'm unmarking this for review for now.
>>>>=20
>>>> I still want review for other improvement suggestions. Thanks in =
advance.
>>>=20
>>> Due to extreme workload, I need a clean or justified Sashiko pass =
first.
>>>=20
>> So is there any guides that I can refer to to mark for false =
positives?
>=20
> Most people reply to the feedback and state the fact, with a little
> background or additional information of course.

I have successfully made the V5 pass the review from Sashiko.

Cheers,

Miao Wang