Re: [PATCH 3/4] mfd: cgbc: Add virtual I2C bus support

Thank you for your contribution! Sashiko AI review found 1 potential issue(=
s) to consider:
- [Low] Hard-coded cell IDs are used for the newly added `cgbc-i2c` subdevi=
ce instead of `PLATFORM_DEVID_AUTO`.
--

--- Patch [3]: [PATCH 3/4] mfd: cgbc: Add virtual I2C bus support ---
commit 4f0038d5dc42bfd45540675cdbf89f68ab3673d5
Author: Thomas Richard (congatec GmbH) <[email protected]>

mfd: cgbc: Add virtual I2C bus support

This commit adds a new I2C cell to support the internal virtual I2C bus=20
provided by the Board Controller.

> diff --git a/drivers/mfd/cgbc-core.c b/drivers/mfd/cgbc-core.c
> index 4a409234e66c8..81bd0a381ca13 100644
> --- a/drivers/mfd/cgbc-core.c
> +++ b/drivers/mfd/cgbc-core.c
> @@ -240,6 +240,7 @@ static struct mfd_cell cgbc_devs[] =3D {
>  	{ .name =3D "cgbc-gpio"	},
>  	{ .name =3D "cgbc-i2c", .id =3D 1 },
>  	{ .name =3D "cgbc-i2c", .id =3D 2 },
> +	{ .name =3D "cgbc-i2c", .id =3D 3 },

[Severity: Low]
Should this use PLATFORM_DEVID_AUTO instead of hard-coding the cell ID?

>  	{ .name =3D "cgbc-hwmon"	},
>  	{ .name =3D "cgbc-backlight" },
>  };

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260804-cgbc-i2c-s=
[email protected]?part=3D3