Re: [PATCH 09/10] dt-bindings: mfd: fsl,mc13xxx: Use generic power-controller schema

[email protected] Tue, 04 Aug 2026 16:10:36 +0000
Newsgroups dev.linux.lists.mfd,org.kernel.vger.linux-devicetree
Message-ID <[email protected]>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Broken schema reference to a nonexistent YAML file.
--

--- Patch [9]: [PATCH 09/10] dt-bindings: mfd: fsl,mc13xxx: Use generic power-controller schema ---
commit eeab4b123a8fd6063871fdea625f14e773ee0aa4
Author: Peng Fan <[email protected]>

dt-bindings: mfd: fsl,mc13xxx: Use generic power-controller schema

This commit switches the fsl,mc13xxx binding to use the generic power
controller schema. It removes the local system-power-controller property
and references the generic power-controller.yaml file.

> diff --git a/Documentation/devicetree/bindings/mfd/fsl,mc13xxx.yaml b/Documentation/devicetree/bindings/mfd/fsl,mc13xxx.yaml
> --- a/Documentation/devicetree/bindings/mfd/fsl,mc13xxx.yaml
> +++ b/Documentation/devicetree/bindings/mfd/fsl,mc13xxx.yaml
[ ... ]
> @@ -174,6 +172,7 @@ required:
>    - reg
>  
>  allOf:
> +  - $ref: /schemas/power/power-controller.yaml#

[Severity: Low]
Does the power-controller.yaml schema exist in the tree yet? 

It appears the generic power controller schema remains a legacy 
power-controller.txt file in this tree. Adding this reference will cause 
make dt_binding_check to fail with a schema reference resolution error 
since the referenced YAML file does not actually exist.

>    - if:
>        properties:
>          compatible:

-- 
Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=9