Re: [PATCH v3 9/9] crypto: atmel: Use dmaengine_prep_config_single() API
Nicolas Ferre <[email protected]>
| Newsgroups | dev.linux.lists.mhi,dev.linux.lists.imx,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-nvme,org.kernel.vger.dmaengine,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-crypto,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pci |
|---|---|
| Organization | microchip |
| Message-ID | <[email protected]> |
On 05/01/2026 at 23:46, Frank Li wrote: > Using new API dmaengine_prep_config_single() to simple code. > > No functional change. > > Tested-by: Niklas Cassel <[email protected]> > Signed-off-by: Frank Li <[email protected]> Looks good to me: Acked-by: Nicolas Ferre <[email protected]> Thanks, best regards, Nicolas > --- > drivers/crypto/atmel-aes.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c > index 3a2684208dda9ee45d71b4bc2958be293a4fb6fe..e300672ffd7185b0f5bf356c2376681537047def 100644 > --- a/drivers/crypto/atmel-aes.c > +++ b/drivers/crypto/atmel-aes.c > @@ -795,7 +795,6 @@ static int atmel_aes_dma_transfer_start(struct atmel_aes_dev *dd, > struct dma_slave_config config; > dma_async_tx_callback callback; > struct atmel_aes_dma *dma; > - int err; > > memset(&config, 0, sizeof(config)); > config.src_addr_width = addr_width; > @@ -820,12 +819,9 @@ static int atmel_aes_dma_transfer_start(struct atmel_aes_dev *dd, > return -EINVAL; > } > > - err = dmaengine_slave_config(dma->chan, &config); > - if (err) > - return err; > - > - desc = dmaengine_prep_slave_sg(dma->chan, dma->sg, dma->sg_len, dir, > - DMA_PREP_INTERRUPT | DMA_CTRL_ACK); > + desc = dmaengine_prep_config_sg(dma->chan, dma->sg, dma->sg_len, dir, > + DMA_PREP_INTERRUPT | DMA_CTRL_ACK, > + &config); > if (!desc) > return -ENOMEM; > > > -- > 2.34.1 >