Re: [PATCH v7 1/2] net: mhi: Enable Ethernet interface support

vivek pernamitta <[email protected]> Wed, 11 Feb 2026 15:54:59 +0530
Newsgroups dev.linux.lists.mhi,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel,org.kernel.vger.netdev
Message-ID <[email protected]>

On 2/10/2026 4:13 PM, Paolo Abeni wrote:
> On 2/5/26 11:34 AM, Vivek Pernamitta wrote:
>> @@ -4,6 +4,7 @@
>>    * Copyright (C) 2020 Linaro Ltd <[email protected]>
>>    */
>>   
>> +#include <linux/etherdevice.h>
>>   #include <linux/if_arp.h>
>>   #include <linux/mhi.h>
>>   #include <linux/mod_devicetable.h>
>> @@ -38,10 +39,12 @@ struct mhi_net_dev {
>>   	u32 rx_queue_sz;
>>   	int msg_enable;
>>   	unsigned int mru;
>> +	bool ethernet_if;
> 
> This is not needed, instead you could check !!dev->header_ops
> 
> /P
> 

As this driver supports only Ethernet and IP net interface types.
Will remove the ethernet_if member from the mhi_net_dev structure
and use net_device->header_ops for interface-type checks