Re: [PATCH] PCI: epf-mhi: return 0 on success instead of positive jiffies
Manivannan Sadhasivam <[email protected]> Thu, 26 Feb 2026 12:50:17 +0530
| Newsgroups | dev.linux.lists.mhi,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pci,org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
On Fri, 06 Feb 2026 15:05:29 -0500, Daniel Hodges wrote:
> wait_for_completion_timeout() returns the number of jiffies remaining
> on success (positive value) or 0 on timeout. The pci_epf_mhi_edma_read()
> and pci_epf_mhi_edma_write() functions use the return value directly as
> their own return value, only converting timeout (0) to -ETIMEDOUT.
>
> On success, they return the positive jiffies value. The callers in
> drivers/bus/mhi/ep/ring.c check for errors with "if (ret < 0)" for
> read_sync and "if (ret)" for write_sync. This causes write_sync success
> cases to be incorrectly treated as errors since the positive jiffies
> value is non-zero.
>
> [...]
Applied, thanks!
[1/1] PCI: epf-mhi: return 0 on success instead of positive jiffies
commit: f6797680fe312ae6d32a773eb4d33400f24555c2
Best regards,
--
Manivannan Sadhasivam <[email protected]>