Re: [PATCH v5 3/3] bus: mhi: ep: clients: Add loopback driver for data path testing

On 8/18/2026 2:23 PM, Uwe Kleine-König wrote:
> Hello,
>
> On Mon, Aug 17, 2026 at 03:44:36PM +0530, Sumit Kumar wrote:
>> diff --git a/drivers/bus/mhi/ep/clients/loopback.c b/drivers/bus/mhi/ep/clients/loopback.c
>> new file mode 100644
>> index 0000000000000000000000000000000000000000..18a92d6a40e0f7de277d155cdb5495d14a60c19d
>> --- /dev/null
>> +++ b/drivers/bus/mhi/ep/clients/loopback.c
>> @@ -0,0 +1,130 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
>> + */
>> +
>> +#include <linux/mhi_ep.h>
>> +#include <linux/mod_devicetable.h>
> Similar as with my feedback for patch #1, please don't use
> <linux/mod_devicetable.h>. Either rely on <linux/mhi_ep.h> ->
> <linux/mhi.h> -> <linux/device-id/mhi.h>, or explicitly include one of
> the these headers but not <linux/mod_devicetable.h>.
Will fix it after rebase in v6.
>
>> +#include <linux/module.h>
>> +#include <linux/string.h>
>> +
>> [...]
>> +static const struct mhi_device_id mhi_ep_loopback_id_table[] = {
>> +	{ .chan = "LOOPBACK"},
>> +	{}
> Again, please add spaces before the closing }.
sure.
>
>> +};
>> +MODULE_DEVICE_TABLE(mhi, mhi_ep_loopback_id_table);
> Best regards
> Uwe