Re: [PATCH mptcp-net v4] mptcp: pm: fix data race in add_addr timer callback

Hi luoqing,

On 23/07/2026 05:23, luoqing wrote:
> From: Qing Luo <[email protected]>
> 
> The timer callback reads entry->retrans_times outside pm.lock to decide
> whether to call mptcp_pm_subflow_established(). Since
> mptcp_pm_announced_del_timer() can concurrently set retrans_times =
> ADD_ADDR_RETRANS_MAX under pm.lock, a race condition exists.
> 
> Use a local 'retransmit' flag set inside pm.lock to capture whether
> retransmission is still possible. This ensures that
> mptcp_pm_subflow_established() is only called when the retransmission
> naturally exhausts.

Reviewed-by: Matthieu Baerts (NGI0) <[email protected]>

Now in our tree:

New patches for t/upstream-net and t/upstream:
- f7a2f9a0e5f5: mptcp: pm: fix data race in add_addr timer callback
- Results: 7455a95067b7..e5d7ab308b5b (export-net)
- Results: 52ff22e1c540..2a68b4bc189c (export)

Tests are now in progress:

- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/3aa4f7a736529c07204d57a41362869f9b777463/checks
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/15a03914501c72388780156b04fb56ca6b01c20e/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.