[PATCH mptcp-next 2/2] selftests: mptcp: simult_flows: set EXIT trap earlier
Gang Yan <[email protected]> Fri, 24 Jul 2026 14:52:29 +0800
| Newsgroups | dev.linux.lists.mptcp |
|---|---|
| Message-ID | <[email protected]> |
From: Gang Yan <[email protected]> Set the EXIT trap for cleanup immediately after creating the temporary file variables, before the dd commands that fill them and the namespace init, to ensure cleanup runs on any failure or interruption during the early setup phase. If either dd fails (e.g. ENOSPC), the temp files already created are not cleaned up. Assisted-by: Codex: GLM-5.2 Signed-off-by: Gang Yan <[email protected]> --- tools/testing/selftests/net/mptcp/simult_flows.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/simult_flows.sh b/tools/testing/selftests/net/mptcp/simult_flows.sh index 3ea3d1efe32e..b40dea5f9b30 100755 --- a/tools/testing/selftests/net/mptcp/simult_flows.sh +++ b/tools/testing/selftests/net/mptcp/simult_flows.sh @@ -62,13 +62,12 @@ setup() sout=$(mktemp) cout=$(mktemp) capout=$(mktemp) + trap cleanup EXIT size=$((2 * 2048 * 4096)) dd if=/dev/zero of=$small bs=4096 count=20 >/dev/null 2>&1 dd if=/dev/zero of=$large bs=4096 count=$((size / 4096)) >/dev/null 2>&1 - trap cleanup EXIT - mptcp_lib_ns_init ns1 ns2 ns3 if $capture; then -- 2.43.0