[PATCH mptcp-next v13 05/12] selftests: mptcp: sockopt: add is_mptcp_socket helper
Geliang Tang <[email protected]> Sun, 26 Jul 2026 16:30:10 +0800
| Newsgroups | dev.linux.lists.mptcp |
|---|---|
| Message-ID | <9eca715549e6b7622c02942055dfffde7a72b21c.1785054129.git.tanggeliang@kylinos.cn> |
From: Geliang Tang <[email protected]> Add a small is_mptcp_socket() helper that issues getsockopt(TCP_IS_MPTCP) and returns whether the fd belongs to an MPTCP socket. Use it to gate the MPTCP-specific assertions: skip do_getsockopts() entirely for plain TCP or fallback MPTCP sockets, and skip mptcpi_rcv_delta checks in connect_one_server()/process_one_client() when the socket is not an MPTCP socket. Signed-off-by: Geliang Tang <[email protected]> --- .../selftests/net/mptcp/mptcp_sockopt.c | 23 ++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_sockopt.c b/tools/testing/selftests/net/mptcp/mptcp_sockopt.c index 3a7fcef5aa54..7e3a28863cbf 100644 --- a/tools/testing/selftests/net/mptcp/mptcp_sockopt.c +++ b/tools/testing/selftests/net/mptcp/mptcp_sockopt.c @@ -557,8 +557,23 @@ static void do_getsockopt_mptcp_full_info(struct so_state *s, int fd) assert(!memcmp(&sfinfo->addrs, &s->addrs, sizeof(struct mptcp_subflow_addrs))); } +static int is_mptcp_socket(int fd) +{ + int is_mptcp = -1; + socklen_t optlen; + + optlen = sizeof(is_mptcp); + if (getsockopt(fd, IPPROTO_TCP, TCP_IS_MPTCP, &is_mptcp, &optlen) == -1) + die_perror("getsockopt TCP_IS_MPTCP"); + + return is_mptcp; +} + static void do_getsockopts(struct so_state *s, int fd, size_t r, size_t w) { + if (is_mptcp_socket(fd) <= 0) + return; + do_getsockopt_mptcp_info(s, fd, w); do_getsockopt_tcp_info(s, fd, r, w); @@ -634,7 +649,8 @@ static void connect_one_server(int fd, int pipefd) if (eof) total += 1; /* sequence advances due to FIN */ - assert(s.mptcpi_rcv_delta == (uint64_t)total); + if (is_mptcp_socket(fd) > 0) + assert(s.mptcpi_rcv_delta == (uint64_t)total); close(fd); } @@ -683,8 +699,9 @@ static void process_one_client(int fd, int pipefd) r += ret; do_getsockopts(&s, fd, r, w); - check_stat_equal("mptcpi_rcv_delta", s.mptcpi_rcv_delta, - (uint64_t)r + 1); /* +1 for FIN */ + if (is_mptcp_socket(fd) > 0) + check_stat_equal("mptcpi_rcv_delta", s.mptcpi_rcv_delta, + (uint64_t)r + 1); /* +1 for FIN */ /* be nice when running on top of older kernel */ if (s.pkt_stats_avail) { -- 2.53.0